ph4 #38
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "ph4"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This commit introduces changes to ensure that Alembic database migrations are automatically applied when the backend Docker container starts. Key changes: - Added `be/entrypoint.sh`: This script first runs `alembic upgrade head` to apply any pending migrations and then executes the main container command (e.g., starting Uvicorn). - Modified `be/Dockerfile`: - The `entrypoint.sh` script is copied into the image and made executable. - The Docker `ENTRYPOINT` is set to this script, ensuring migrations run before the application starts. - Updated `docker-compose.yml`: - The `DATABASE_URL` for the `backend` service has been set to the Neon database URL you provided. - Verified `be/alembic/env.py`: Confirmed that it correctly sources the `DATABASE_URL` from environment variables for Alembic to use. These changes address the issue where migrations were not being run, preventing the application from starting correctly.This commit addresses two issues: 1. A `TypeError` during Alembic migrations (`upgrade() takes 0 positional arguments but 1 was given`). This was caused by the `upgrade` and `downgrade` functions in the initial migration script not accepting any arguments, while the custom migration runner in `migrations.py` was passing a context argument. - Modified `be/alembic/versions/0001_initial_schema.py` to ensure `upgrade` and `downgrade` functions accept a `context` argument. 2. Redundant execution of migrations. Migrations were being triggered both by the `entrypoint.sh` script and within the FastAPI application's startup event in `app/main.py`. - Commented out the `await run_migrations()` call in `app/main.py` to ensure migrations are only handled by the `entrypoint.sh` script. These changes should ensure that database migrations run correctly and only once when the backend container starts.